Add support for configuring Multi-Instance GPUs (MIG)#656
Merged
Conversation
sjpb
requested changes
Apr 24, 2025
Collaborator
sjpb
left a comment
sjpb
left a comment
There was a problem hiding this comment.
Mostly comments re. where stuff is, and some minor typos etc
jovial
force-pushed
the
feature/mig
branch
3 times, most recently
from
994d8f6 to
abf35e5
Compare
sjpb
reviewed
May 8, 2025
jovial
commented
May 8, 2025
sjpb
requested changes
May 8, 2025
Collaborator
sjpb
left a comment
sjpb
left a comment
There was a problem hiding this comment.
Realised a few other changes required from the stackhpc.openhpc bump - we might want to factor those out, potentially - you won't really care about them for client.
6 tasks
sjpb
requested changes
May 23, 2025
jovial
force-pushed
the
feature/mig
branch
3 times, most recently
from
a4823a3 to
83ec813
Compare
jovial
force-pushed
the
feature/mig
branch
3 times, most recently
from
9560d96 to
1c2d07d
Compare
Collaborator
|
Failing builds appear to be #685 |
jovial
commented
Jun 11, 2025
jovial
commented
Jun 11, 2025
sjpb
changed the title
sjpb
requested changes
Jun 17, 2025
Collaborator
sjpb
left a comment
sjpb
left a comment
There was a problem hiding this comment.
LGTM other than a worry about the branch being out of date and hence testing applicability to main.
sjpb
changed the title
Collaborator
Collaborator
|
Actually I'm going to do this in a new branch, the merge squash means this branch will conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See
docs/mig.md.The
stackhpc.openhpcrole has been bumped to support the NVIDIA GPU autodection required for MIG configuration.NB: This role bump also means parameters can be removed from slurm.conf, see stackhpc/ansible-role-openhpc#184